Editorial: make changes requested by ECMA ExeCom #140
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adjust the title
* Moved "about this specification" to the introduction section
* Add new scope language
* Re-ordered sections: Scope, Conformance, References, Term and Definitions
* Manually generate the references section
- It doesn't seem possible to generate the references as a normal
numbered section without this manual approach, which is a hack.
Comment on lines
+223
to
+233
| <!-- | ||
| NOTE: This references section is manually generated because bikeshed assumes | ||
| that the references section should be un-numbered and we want to include | ||
| it as a numbered section. To generate it, use the following and then | ||
| copy the inner HTML contents: | ||
|
|
||
| <div data-fill-with="references"></div> | ||
|
|
||
| and replace [ with \[ to escape macros. Also add data-no-self-link="" to | ||
| each <dt> entry. | ||
| --> |
jridgewell
approved these changes
Oct 26, 2024
973a715 to
efc38d1
Compare
nicolo-ribaudo
approved these changes
Oct 28, 2024
jkup
approved these changes
Oct 30, 2024
|
I tried "close and reopen" because this PR was stuck while merging, and now I cannot reopen. @takikawa could you open a new PR from the same branch? 😅 |
|
Ok nevermind, it has been successfully merged even if GitHub says no |
szuend
pushed a commit
to szuend/source-map
that referenced
this pull request
Nov 4, 2024
Editorial: make changes requested by ECMA ExeCom
github-actions bot
added a commit
to szuend/source-map
that referenced
this pull request
Nov 4, 2024
SHA: 8be0fe1 Reason: push, by szuend Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to szuend/source-map
that referenced
this pull request
Nov 6, 2024
SHA: 8be0fe1 Reason: push, by szuend Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
nicolo-ribaudo
pushed a commit
that referenced
this pull request
Nov 11, 2024
Editorial: make changes requested by ECMA ExeCom
github-actions bot
added a commit
to nicolo-ribaudo/source-map
that referenced
this pull request
Nov 11, 2024
SHA: 8be0fe1 Reason: push, by nicolo-ribaudo Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Nov 11, 2024
SHA: 6dc57d3 Reason: push, by nicolo-ribaudo Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains editorial changes based on recent feedback from ECMA for the current draft. See the commit message for details.