Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: add [[AgentSignifier]] to Realm Record #3058

Merged
merged 1 commit into from
May 20, 2023

Conversation

syg
Copy link
Contributor

@syg syg commented May 8, 2023

No description provided.

@syg
Copy link
Contributor Author

syg commented May 8, 2023

I contend this is editorial because a lot of things wouldn't make sense if realms don't belong to exactly one agent: things like [[KeptAlive]] being able to change under the hood would be bad.

spec.html Show resolved Hide resolved
@jmdyck
Copy link
Collaborator

jmdyck commented May 9, 2023

Fixes #1357

The first post of that issue is asking for more than what this PR provides.

@syg
Copy link
Contributor Author

syg commented May 9, 2023

Fixes #1357

I think the realm -> agent pointer is the most glaring thing that ought to be fixed, I'd rather think through the other parts like the symbol registry afterwards. I can remove the "Fixed #1357" bit from the commit message.

@syg syg mentioned this pull request May 10, 2023
3 tasks
@syg syg requested a review from bakkot May 19, 2023 18:28
@syg
Copy link
Contributor Author

syg commented May 19, 2023

@bakkot PTAL, small pre-req PR for Atomics.waitAsync.

@bakkot bakkot added the ready to merge Editors believe this PR needs no further reviews, and is ready to land. label May 19, 2023
@ljharb ljharb force-pushed the realm-agent-connection branch from 671fa9b to 1153003 Compare May 19, 2023 20:20
@ljharb ljharb merged commit 1153003 into tc39:main May 20, 2023
domenic pushed a commit to whatwg/html that referenced this pull request May 31, 2023
rubberyuzu pushed a commit to rubberyuzu/html that referenced this pull request Jun 13, 2023
rubberyuzu pushed a commit to rubberyuzu/html that referenced this pull request Jun 20, 2023
rubberyuzu pushed a commit to rubberyuzu/html that referenced this pull request Jul 20, 2023
rubberyuzu pushed a commit to rubberyuzu/html that referenced this pull request Jul 21, 2023
Follows tc39/ecma262#3058. See tc39/ecma262#1357 for more background.

Adding final step to mask cross-origin

Mask preventedBFCache

Call build nrr for page from unload

fix indentation

Use set to
rubberyuzu pushed a commit to rubberyuzu/html that referenced this pull request Jul 21, 2023
Follows tc39/ecma262#3058. See tc39/ecma262#1357 for more background.

Adding final step to mask cross-origin

Mask preventedBFCache

Call build nrr for page from unload

fix indentation

Use set to
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial change ready to merge Editors believe this PR needs no further reviews, and is ready to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants