-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editorial: add [[AgentSignifier]] to Realm Record #3058
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I contend this is editorial because a lot of things wouldn't make sense if realms don't belong to exactly one agent: things like [[KeptAlive]] being able to change under the hood would be bad. |
jmdyck
reviewed
May 9, 2023
The first post of that issue is asking for more than what this PR provides. |
michaelficarra
approved these changes
May 9, 2023
@bakkot PTAL, small pre-req PR for |
bakkot
approved these changes
May 19, 2023
bakkot
added
the
ready to merge
Editors believe this PR needs no further reviews, and is ready to land.
label
May 19, 2023
ljharb
force-pushed
the
realm-agent-connection
branch
from
May 19, 2023 20:20
671fa9b
to
1153003
Compare
domenic
pushed a commit
to whatwg/html
that referenced
this pull request
May 31, 2023
Follows tc39/ecma262#3058. See tc39/ecma262#1357 for more background.
rubberyuzu
pushed a commit
to rubberyuzu/html
that referenced
this pull request
Jun 13, 2023
Follows tc39/ecma262#3058. See tc39/ecma262#1357 for more background.
rubberyuzu
pushed a commit
to rubberyuzu/html
that referenced
this pull request
Jun 20, 2023
Follows tc39/ecma262#3058. See tc39/ecma262#1357 for more background.
rubberyuzu
pushed a commit
to rubberyuzu/html
that referenced
this pull request
Jul 20, 2023
Follows tc39/ecma262#3058. See tc39/ecma262#1357 for more background.
rubberyuzu
pushed a commit
to rubberyuzu/html
that referenced
this pull request
Jul 21, 2023
Follows tc39/ecma262#3058. See tc39/ecma262#1357 for more background. Adding final step to mask cross-origin Mask preventedBFCache Call build nrr for page from unload fix indentation Use set to
rubberyuzu
pushed a commit
to rubberyuzu/html
that referenced
this pull request
Jul 21, 2023
Follows tc39/ecma262#3058. See tc39/ecma262#1357 for more background. Adding final step to mask cross-origin Mask preventedBFCache Call build nrr for page from unload fix indentation Use set to
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
editorial change
ready to merge
Editors believe this PR needs no further reviews, and is ready to land.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.