Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: move assertions about AO parameter types into AO header metadata #2483

Merged
merged 1 commit into from
Aug 25, 2021
Merged

Editorial: move assertions about AO parameter types into AO header metadata #2483

merged 1 commit into from
Aug 25, 2021

Conversation

michaelficarra
Copy link
Member

No description provided.

bakkot
bakkot reviewed Aug 5, 2021
View reviewed changes
spec.html Outdated Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
spec.html Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
jmdyck
jmdyck requested changes Aug 5, 2021
View reviewed changes
spec.html Outdated Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
jmdyck
jmdyck reviewed Aug 9, 2021
View reviewed changes
spec.html Outdated Show resolved Hide resolved
@michaelficarra michaelficarra added editor call to be discussed in the next editor call and removed editor call to be discussed in the next editor call labels Aug 9, 2021
@michaelficarra
Copy link
Member Author

@bakkot All comments addressed. Please review again.

This was referenced Aug 12, 2021
Closed
Open
@bakkot bakkot mentioned this pull request Aug 15, 2021
Merged
bakkot
bakkot approved these changes Aug 15, 2021
View reviewed changes
Copy link
Contributor

@bakkot bakkot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but #2489 should maybe land first.

jmdyck
jmdyck previously requested changes Aug 17, 2021
View reviewed changes
Copy link
Collaborator

@jmdyck jmdyck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a bunch of similar changes for other operations, so I'll put them in a PR against this PR's branch.

spec.html Outdated Show resolved Hide resolved
@jmdyck jmdyck mentioned this pull request Aug 17, 2021
Merged
@michaelficarra
Copy link
Member Author

@jmdyck Thanks. Merged.

@bakkot
Copy link
Contributor

bakkot commented Aug 24, 2021

This needs a rebase now that #2489 landed.

@michaelficarra michaelficarra force-pushed the move-assertions-to-metadata branch from e27dc5e to 1e21bca Compare August 25, 2021 16:48
@michaelficarra
Copy link
Member Author

Rebased.

bakkot
bakkot approved these changes Aug 25, 2021
View reviewed changes
Copy link
Contributor

@bakkot bakkot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM. :shipit:

@bakkot bakkot added the ready to merge Editors believe this PR needs no further reviews, and is ready to land. label Aug 25, 2021
ljharb
ljharb reviewed Aug 25, 2021
View reviewed changes
spec.html Show resolved Hide resolved
@ljharb ljharb force-pushed the move-assertions-to-metadata branch from 1e21bca to 4fde514 Compare August 25, 2021 21:35
@ljharb ljharb dismissed jmdyck’s stale review August 25, 2021 21:36

changes addressed

@ljharb ljharb merged commit 4fde514 into master Aug 25, 2021
@ljharb ljharb deleted the move-assertions-to-metadata branch August 25, 2021 21:42
jmdyck added a commit to jmdyck/ecma262 that referenced this pull request Sep 14, 2021
@jmdyck
Editorial: Eliminate "either" at start of parameter 'type'
e0c631c 
PR tc39#2483 dropped "either" when transferring from Assert to param-type,
but didin't touch occurrences of "either" that were already there (from PR tc39#545).
This commit eliminates the latter.
ljharb pushed a commit to jmdyck/ecma262 that referenced this pull request Sep 14, 2021
@jmdyck @ljharb
Editorial: Eliminate "either" at start of parameter 'type' (tc39#2513)
5e42158 
PR tc39#2483 dropped "either" when transferring from Assert to param-type, but didn't touch occurrences of "either" that were already there (from PR tc39#545).
This commit eliminates the latter.
mathiasbynens pushed a commit to mathiasbynens/ecma262 that referenced this pull request Oct 18, 2021
@michaelficarra @mathiasbynens
Editorial: move assertions about AO parameter types into AO header me…
a6ffb7d 
…tadata (tc39#2483)
mathiasbynens pushed a commit to mathiasbynens/ecma262 that referenced this pull request Oct 18, 2021
@jmdyck @mathiasbynens
Editorial: Eliminate "either" at start of parameter 'type' (tc39#2513)
35495d6 
PR tc39#2483 dropped "either" when transferring from Assert to param-type, but didn't touch occurrences of "either" that were already there (from PR tc39#545).
This commit eliminates the latter.
@jmdyck jmdyck mentioned this pull request Aug 24, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb left review comments

@arhadthedev arhadthedev arhadthedev left review comments

@bakkot bakkot bakkot approved these changes

@jmdyck jmdyck jmdyck left review comments

Assignees
No one assigned
Labels
editorial change ready to merge Editors believe this PR needs no further reviews, and is ready to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@michaelficarra @bakkot @ljharb @jmdyck @arhadthedev