Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: convert Number abstract operations to algorithmic steps #2189

Merged
merged 1 commit into from
Feb 6, 2021
Merged

Editorial: convert Number abstract operations to algorithmic steps #2189

merged 1 commit into from
Feb 6, 2021

Conversation

ryanjduffy
Copy link

@ryanjduffy ryanjduffy commented Sep 23, 2020 •
edited
Loading

Draft to fix #2179

  • Number::exponentiate
  • Number::multiply
  • Number::divide
  • Number::remainder
  • Number::add

michaelficarra
michaelficarra reviewed Sep 24, 2020
View reviewed changes
michaelficarra
michaelficarra reviewed Sep 24, 2020
View reviewed changes
michaelficarra
michaelficarra reviewed Sep 24, 2020
View reviewed changes
michaelficarra
michaelficarra reviewed Sep 24, 2020
View reviewed changes
michaelficarra
michaelficarra reviewed Sep 24, 2020
View reviewed changes
@michaelficarra
Copy link
Member

@ryanjduffy Are you still planning on finishing this PR?

@michaelficarra michaelficarra changed the title Convert Number abstract operations to algorithmic steps Editorial: convert Number abstract operations to algorithmic steps Jan 5, 2021
bakkot
bakkot reviewed Jan 6, 2021
View reviewed changes
@michaelficarra michaelficarra marked this pull request as ready for review January 6, 2021 05:08
@michaelficarra michaelficarra requested review from a team, syg and bakkot January 6, 2021 18:13
bakkot
bakkot reviewed Jan 7, 2021
View reviewed changes
Copy link
Contributor

@bakkot bakkot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some editorial comments, but otherwise looks good to me.

@ryanjduffy
Copy link
Author

@michaelficarra - Thanks for picking this up from me. Life got in the way over the past few months. :) I'll keep an eye out for other issues I can pick up in the near future.

@michaelficarra
Copy link
Member

No worries, @ryanjduffy. Thanks for the work you had already done. I'd love to see more contributions from you in the future, but don't feel pressured.

bakkot
bakkot reviewed Jan 9, 2021
View reviewed changes
@michaelficarra
Copy link
Member

@bakkot Addressed.

jmdyck
jmdyck previously requested changes Jan 11, 2021
View reviewed changes
@bakkot bakkot mentioned this pull request Feb 4, 2021
Open
@bakkot bakkot added the ready to merge Editors believe this PR needs no further reviews, and is ready to land. label Feb 5, 2021
@ljharb ljharb requested a review from jmdyck February 6, 2021 03:20
jmdyck
jmdyck reviewed Feb 6, 2021
View reviewed changes
Copy link
Collaborator

@jmdyck jmdyck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No complaints, but I didn't check that the changes were semantics-preserving.

@ljharb ljharb dismissed jmdyck’s stale review February 6, 2021 16:33

changes addressed

@michaelficarra @bakkot @ljharb
Editorial: convert Number abstract operations to algorithmic steps (t…
5c9f191 
…c39#2189)

Co-authored-by: Ryan Duffy <ryan.duffy@lge.com>
Co-authored-by: Michael Ficarra <mficarra@shapesecurity.com>
Co-authored-by: Kevin Gibbons <bakkot@gmail.com>
ljharb
ljharb approved these changes Feb 6, 2021
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified all changes against my es-abstract implementations and tests.

@ljharb ljharb merged commit 5c9f191 into tc39:master Feb 6, 2021
@ryanjduffy ryanjduffy deleted the issue-2179 branch October 6, 2021 19:24
@michaelficarra michaelficarra mentioned this pull request Jan 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelficarra michaelficarra michaelficarra left review comments

@bakkot bakkot bakkot approved these changes

@jmdyck jmdyck jmdyck left review comments

@ljharb ljharb ljharb approved these changes

@syg syg syg approved these changes

Assignees
No one assigned
Labels
editorial change establishes editorial conventions ready to merge Editors believe this PR needs no further reviews, and is ready to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

convert some Number:: AOs to use algorithm steps
6 participants
@ryanjduffy @michaelficarra @ljharb @syg @bakkot @jmdyck