[editorial] Fix typo in NewPromiseReactionJob #1893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimothyGu
approved these changes
Mar 10, 2020
devsnek
approved these changes
Mar 10, 2020
ljharb
approved these changes
Mar 10, 2020
ljharb
referenced
this pull request
Apr 2, 2020
This layering change retains the PendingJob concept but sends PendingJob records off to the host to be dispatched at the appropriate time, replacing the RunJobs algorithm. The change is expected to help specify the interaction between Promises, WeakRefs and the Web more precisely, while maintaining all current invariants. Co-authored-by: Domenic Denicola <d@domenic.me> Co-authored-by: Daniel Ehrenberg <littledan@chromium.org> Co-authored-by: Shu-yu Guo <syg@chromium.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @devsnek for the catch from #1597