Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normative: Properly handle Number(BigInt) #1766

Merged
merged 1 commit into from
Nov 19, 2019
Merged

Normative: Properly handle Number(BigInt) #1766

merged 1 commit into from
Nov 19, 2019

Conversation

caiolima
Copy link
Contributor

@caiolima caiolima commented Oct 31, 2019 •
edited by ljharb
Loading

It closes #1754. This change is missing from original BigInt additions (#1515), but it was specified in the BigInt spec text.

CC @littledan @devsnek @ljharb

@devsnek
Copy link
Member

devsnek commented Oct 31, 2019

is "the number value for prim" specified somewhere? should it have an xref link?

@caiolima
Copy link
Contributor Author

is "the number value for prim" specified somewhere? should it have an xref link?

It is specified in https://tc39.es/ecma262/#number-value. It already linking to the definition properly (see the result here)

@devsnek
Copy link
Member

devsnek commented Oct 31, 2019

fantastic.

@ljharb ljharb added normative change Affects behavior required to correctly evaluate some ECMAScript source text spec bug labels Oct 31, 2019
@ljharb ljharb requested review from syg, michaelficarra, littledan, bakkot, devsnek and a team October 31, 2019 20:50
@ljharb ljharb self-assigned this Oct 31, 2019
bakkot
bakkot approved these changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@bakkot bakkot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should figure out if bugfix PRs like this one should be marked as editorial or normative, but spec text LGTM.

@devsnek
Copy link
Member

devsnek commented Oct 31, 2019

definitely normative imo

@ljharb
Copy link
Member

ljharb commented Oct 31, 2019

Normative is anything observable in the runtime, so definitely normative.

@caiolima caiolima force-pushed the number-constructor-big-int-support branch from 06b1852 to 7874c2c Compare October 31, 2019 22:55
@caiolima caiolima changed the title Editorial: Properly handle Number(BigInt) Normative: Properly handle Number(BigInt) Oct 31, 2019
@lizhongzhen11 lizhongzhen11 mentioned this pull request Nov 14, 2019
Open
syg
syg approved these changes Nov 19, 2019
View reviewed changes
Copy link
Contributor

@syg syg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMG-0390

ljharb pushed a commit to caiolima/ecma262 that referenced this pull request Nov 19, 2019
@caiolima @ljharb
Normative: Properly handle Number(BigInt) (tc39#1766)
6e64bba
@ljharb ljharb force-pushed the number-constructor-big-int-support branch from 7874c2c to 6e64bba Compare November 19, 2019 06:26
@ljharb ljharb force-pushed the number-constructor-big-int-support branch from 6e64bba to 308d61e Compare November 19, 2019 06:29
@ljharb ljharb merged commit 308d61e into tc39:master Nov 19, 2019
@jmdyck jmdyck mentioned this pull request Nov 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devsnek devsnek devsnek approved these changes

@bakkot bakkot bakkot approved these changes

@michaelficarra michaelficarra michaelficarra approved these changes

@syg syg syg approved these changes

@ljharb ljharb ljharb approved these changes

@littledan littledan Awaiting requested review from littledan

Assignees

@ljharb ljharb

Labels
normative change Affects behavior required to correctly evaluate some ECMAScript source text spec bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Number(bigint) is not properly specified
6 participants
@caiolima @devsnek @ljharb @syg @michaelficarra @bakkot