Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normative: Make BigInt a global #1753

Merged
merged 1 commit into from
Oct 26, 2019
Merged

Normative: Make BigInt a global #1753

merged 1 commit into from
Oct 26, 2019

Conversation

devsnek
Copy link
Member

@devsnek devsnek commented Oct 24, 2019 •
edited by ljharb
Loading

Missing from #1515.

@ljharb ljharb added normative change Affects behavior required to correctly evaluate some ECMAScript source text spec bug labels Oct 24, 2019
@ljharb ljharb requested review from syg, littledan, caiolima and a team October 24, 2019 14:59
ljharb
ljharb approved these changes Oct 24, 2019
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, seems like a straightforward omission.

@ljharb ljharb self-assigned this Oct 24, 2019
@devsnek
Copy link
Member Author

devsnek commented Oct 24, 2019

^ also added BigInt64Array and BigUint64Array

michaelficarra
michaelficarra approved these changes Oct 25, 2019
View reviewed changes
Copy link
Member

@michaelficarra michaelficarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😲 wow

syg
syg approved these changes Oct 25, 2019
View reviewed changes
Copy link
Contributor

@syg syg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice...

caiolima
caiolima approved these changes Oct 26, 2019
View reviewed changes
Copy link
Contributor

@caiolima caiolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch.

@ljharb ljharb force-pushed the fix-bigint-global branch from dce6831 to 34ae511 Compare October 26, 2019 21:26
@ljharb ljharb merged commit 34ae511 into tc39:master Oct 26, 2019
@devsnek devsnek deleted the fix-bigint-global branch October 26, 2019 21:33
jmdyck added a commit to jmdyck/ecma262 that referenced this pull request Oct 27, 2019
@jmdyck
Editorial: Move "Boolean ( . . . )" clause
719abf3 
PR tc39#1753 inserted the BigInt* clauses after Boolean,
but they should be *before* Boolean.
@jmdyck jmdyck mentioned this pull request Oct 27, 2019
Merged
ljharb pushed a commit to jmdyck/ecma262 that referenced this pull request Oct 27, 2019
@jmdyck @ljharb
Editorial: Move "Boolean ( . . . )" clause (tc39#1762)
7fc703f 
PR tc39#1753 inserted the BigInt* clauses after Boolean, but they should be before Boolean.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

@syg syg syg approved these changes

@michaelficarra michaelficarra michaelficarra approved these changes

@caiolima caiolima caiolima approved these changes

@littledan littledan Awaiting requested review from littledan

Assignees

@ljharb ljharb

Labels
normative change Affects behavior required to correctly evaluate some ECMAScript source text spec bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@devsnek @ljharb @syg @michaelficarra @caiolima