Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normative: IsSimpleParameterList is false for standalone rest parameters #1608

Conversation

gibson042
Copy link
Contributor

I noticed in passing that this case was missing.

@ljharb

This comment has been minimized.

@devsnek
Copy link
Member

devsnek commented Jul 2, 2019

all the engines throw a syntax error for it (except xs, known bug) 🤷‍♂️

@ljharb
Copy link
Member

ljharb commented Jul 3, 2019

Technically i think this is normative.

@gibson042
Copy link
Contributor Author

I wondered about that, but settled on editorial with the presumption that the behavior was understood to be expected but just hadn't been correctly represented in spec text.

@jmdyck
Copy link
Collaborator

jmdyck commented Jul 3, 2019

I plugged this hole in this commit of PR #1301.

(And I decided it was editorial too.)

@ljharb
Copy link
Member

ljharb commented Jul 3, 2019

I'd consider it a normative spec bug; imo editorial is exclusively for things that aren't observable.

@gibson042 gibson042 added spec bug normative change Affects behavior required to correctly evaluate some ECMAScript source text labels Jul 3, 2019
@gibson042 gibson042 changed the title Editorial: IsSimpleParameterList is false for standalone rest parameters Normative: IsSimpleParameterList is false for standalone rest parameters Jul 3, 2019
@anba
Copy link
Contributor

anba commented Jul 19, 2019

FWIW this is a regression from 6a06509

@ljharb ljharb requested review from zenparsing, ljharb, jeffmo and a team July 19, 2019 15:48
@ljharb ljharb requested review from waldemarhorwat and devsnek and removed request for zenparsing September 30, 2019 20:43
@ljharb ljharb requested a review from syg October 18, 2019 06:28
ljharb pushed a commit to gibson042/ecma262 that referenced this pull request Nov 9, 2019
@ljharb ljharb force-pushed the 2019-07-IsSimpleParameterList-FunctionRestParameter branch from e0b9ea5 to 4e75c78 Compare November 9, 2019 04:26
@ljharb ljharb requested a review from bakkot November 18, 2019 22:44
@ljharb ljharb force-pushed the 2019-07-IsSimpleParameterList-FunctionRestParameter branch from 4e75c78 to 19e88da Compare November 18, 2019 23:23
@ljharb ljharb merged commit 19e88da into tc39:master Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
normative change Affects behavior required to correctly evaluate some ECMAScript source text spec bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants