meta: add snapshot builds for pr previews #1525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
previously requested changes
Apr 30, 2019
2e9a867 to
8c016c4
Compare
|
i managed to make this automatically apply the snapshot thing if netlify is building a non-production build. if this was set up for this repo, it believe it would automatically post this link when the pr was created. preview: https://5ce61b1a493e120007e63323--brave-elion-abb3d4.netlify.com/ vs https://brave-elion-abb3d4.netlify.com/ settings i used: |
ljharb
reviewed
May 23, 2019
ljharb
reviewed
Aug 6, 2019
ljharb
pushed a commit
to devsnek/ecma262
that referenced
this pull request
Aug 29, 2019
ljharb
pushed a commit
to devsnek/ecma262
that referenced
this pull request
Aug 29, 2019
|
I rebased this and made the requested JSDOM.fromFile changes, and added the contentType option with a charset parameter to avoid garbling the UTF-8 characters. |
ljharb
pushed a commit
to devsnek/ecma262
that referenced
this pull request
Sep 5, 2019
13b1ba7 to
85f905a
Compare
ljharb
approved these changes
Sep 5, 2019
pretty sure changes are addressed; everything's working, so we can clean things up in a followup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit adds a warning (stolen from whatpr.org) to "snapshot" builds that exist for non-reference reasons, such as pr previews.
if we add some sort of github action to auto deploy netlify or something on a new pr and then post a comment with the url, this will provide a nice preview. someone with permissions on this repo will have to set that part up.
rendered: https://5ce61b1a493e120007e63323--brave-elion-abb3d4.netlify.com/