Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: fix assertion in IteratorBindingInitialization #1356

Merged
merged 1 commit into from
Apr 10, 2019
Merged

Editorial: fix assertion in IteratorBindingInitialization #1356

merged 1 commit into from
Apr 10, 2019

Conversation

devsnek
Copy link
Member

@devsnek devsnek commented Nov 25, 2018

environment will be undefined if the formal parameters contain duplicates

@ljharb ljharb added normative change Affects behavior required to correctly evaluate some ECMAScript source text spec bug labels Nov 25, 2018
@ljharb ljharb requested review from bterlson, zenparsing and a team November 25, 2018 23:58
@ljharb ljharb added editorial change and removed normative change Affects behavior required to correctly evaluate some ECMAScript source text labels Nov 26, 2018
@zenparsing
Copy link
Member

This looks right. We might just want to remove the assertion though; I'm not sure the corrected form helps to clarify the algorithm much.

@ljharb ljharb requested review from a team and removed request for bterlson February 28, 2019 19:55
@ljharb ljharb self-assigned this Mar 7, 2019
@ljharb ljharb force-pushed the fix/assert-in-iteratorinit branch from 53102ff to 69d6a69 Compare March 27, 2019 14:22
ljharb pushed a commit to devsnek/ecma262 that referenced this pull request Mar 27, 2019
@devsnek @ljharb
Editorial: fix assertion in IteratorBindingInitialization (tc39#1356)
69d6a69
@ljharb ljharb force-pushed the fix/assert-in-iteratorinit branch from 69d6a69 to 89ccf22 Compare April 3, 2019 22:00
ljharb pushed a commit to devsnek/ecma262 that referenced this pull request Apr 3, 2019
@devsnek @ljharb
Editorial: fix assertion in IteratorBindingInitialization (tc39#1356)
89ccf22
@ljharb ljharb force-pushed the fix/assert-in-iteratorinit branch from 89ccf22 to 84d7b5a Compare April 10, 2019 22:15
@ljharb ljharb merged commit 84d7b5a into tc39:master Apr 10, 2019
@devsnek devsnek deleted the fix/assert-in-iteratorinit branch April 10, 2019 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

@zenparsing zenparsing zenparsing approved these changes

Assignees

@ljharb ljharb

Labels
editorial change spec bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devsnek @zenparsing @ljharb @bterlson