friendship page now has the option to show settled transactions #6
Conversation
| let relatedObjectId = this.get('friendship.friendshipDataId') | ||
|
|
||
| let settledTransactions = this.get('store').filter('transaction', t => { | ||
| console.log(t.get('memo')) |
| @@ -11,7 +11,8 @@ let Transaction = DS.Model.extend({ | |||
| creator: DS.belongsTo('user'), | |||
| createdAt: DS.attr('Date', { | |||
| defaultValue: function() { return new Date() } | |||
| }) | |||
| }), | |||
| is_settled: DS.attr('boolean') | |||
There was a problem hiding this comment.
property name should be camelCase (isSettled). Also, should move it between amount and model properties.
|
@Bbowen100 Tested it out and it works 👍 . I did leave some comments that are mostly stylistic. What was the need to create a separate component for the Also, the current main transaction list shows all transactions, we'd like to filter that to only show un settled transactions. If users want to see settled transactions, they can open up the collapsed list. |
|
What was the need to create a separate component for the settled-list. Why couldn't we just expand the transaction-list component to accomodate for this?
Also, the current main transaction list shows all transactions, we'd like to filter that to only show un settled transactions. If users want to see settled transactions, they can open up the collapsed list.
|
…ows only unsettled transactions
…n-list, added property to differentiate between settled and unsettled transactions, changed settled-transaction button to full width of component
| @@ -0,0 +1,26 @@ | |||
| import { moduleForComponent, test } from 'ember-qunit'; | |||
There was a problem hiding this comment.
We don't need this file anymore.
|
@Bbowen100 minor changes recommended. Good work on the PR. |
|
|
||
| .btn.settle-transaction { |
There was a problem hiding this comment.
We're using this class else where, don't need to remove it.
|
Looks good 👍 |
No description provided.