Spinbox was showing units even if the model use fragments to display only the magnitude

[srgblnch]

I've seen that a TaurusValueSpinBox was still showing the units in widgets where the model say, in the fragment, that only the magnitude was to be shown.

This pull request contains 2 commits. The first one was changes in the main function at the end of the file, for testing purposes (as well as a pep8 review). Then, like the main in the tauruslabel one can pass some attributes as arguments.

The commit with the solution itself is the second. There is a single change in the TaurusValueLineEdit.setValue(self, v). It was using self.displayValue(v) when the method that manages with the fragments is getDisplayValue.

/Sergi.

[cpascual]

The proposed implementation has one problem: now by default the shown value is rvalue (while in this widget it shoud be wvalue).

This can be checked easily with an attribute such as sys/tg_test/1/short_scalar whose wvalue and rvalue are not the same:

from taurus.qt.qtgui.application import TaurusApplication
from taurus.qt.qtgui.input import TaurusValueLineEdit

if __name__ == '__main__':
    import sys
    app = TaurusApplication()

    w = TaurusValueLineEdit()

    model = 'sys/tg_test/1/short_scalar'
    w.setModel(model)

    w.show()
    sys.exit(app.exec_())

[srgblnch]

Then I will need a hint. TaurusBaseComponent.getDisplayValue(...) seems to only manage the fragment thing, to then call the TaurusBaseComponent.displayValue(...) that the TaurusValueLineEdit.setValue(...) was calling before.

Using the modification I've made in the main of the tauruslineedit.py to allow just this testing, I call:
$ python lib/taurus/qt/qtgui/input/tauruslineedit.py sys/tg_test/1/short_scalar sys/tg_test/1/short_scalar#rvalue.magnitude sys/tg_test/1/short_scalar#wvalue.magnitude

And yes, when the patched code is called without a fragment the value shown is the rvalue. This may play with the fragmentName argument? Sorry but the help in the methods is not helping me to understand them.

[srgblnch]

Perhaps the TaurusBaseWritableWidget.setModel(...) (that is not implemented and is using the one in the superclass TaurusBaseComponent) should modify the defaultFragmentName to change on the writable things from 'rvalue' to 'wvalue'?

[srgblnch]

Would this third commit be good enough to prevent the behaviour of showing the rvalue when no fragment is shown?

By the way, the bugfix doesn't interfere the superclass, as we have spoken, in order avoid an API impact.

[cpascual]

This is not critical , but... most taurus code avoids using super because of some issues with diamond inheritance schemes, so I would prefer the following implementation:

def getDisplayValue(self, cache=True, fragmentName=None):
    if fragmentName is None and self.modelFragmentName is None:
        fragmentName = 'wvalue'
    return TaurusBaseWidget.getDisplayValue(self, cache=cache, fragmentName=fragmentName)

[srgblnch]

Then this TaurusValueLineEdit.getDisplayValue() may call the newer TaurusBaseWritableWidget.getDisplayValue() instead of the supersuperclass. Even it's an empty call right now, if this is propagated up one would realise better the scale.

[cpascual]

100% right. It should be TaurusBaseWritableWidget.getDisplayValue

My mistake

[cpascual]

I would avoid using super (see my other comment)

[cpascual]

Merging, with two minor changes.

Thanks @srgblnch !