This repository has been archived by the owner on Mar 17, 2021. It is now read-only.
Release jul20 #1127
Merged
Release jul20 #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Avoid caching formatters - Simplify logic - support py3 and py2 - Offer the registered formatters, the DEFAULT_FORMATTER, the class formatter and the current formatter in the combobox
The sorting of known_formatters fails on py2. Since it is not critical, just do not do it.
TauruBaseWidget.showFormatterDlg's API does not allow to distinguish between a cancelled dialog and a selection of None as formatter. Deprecate it and fix the API directly in onSetFormatter()
Tango is not thread safe when using threading.Thread. One must use omni threads instead. This was confirmed for parallel event subscriptions in PyTango#307. For example, in the case of Sardana, the custom Worker will be protected by the EnsureOmniThread context manager intoroduced in PyTango#327.
The Taurus JDraw viewer gets an exception if JDBar item is used in the jdw file because TaurusJDrawGraphicsFactory does not support it. Work around this by implementing a dummy support for JDBar. Note that this is not proper support, but just a workaround that displays a filled JDRectangle instead of a bar to allow parsing.
Use .rvalue instead
Allow to customize Worker for ThreadPool
Avoid NoneType AttributeError
Fix missing precision initialization
By mistake, self_format was used instead of self.FORMAT in the previous refactoring. This breaks the formatter API. Fix it.
Improve set formatter dialog
Improve v3->v4 migration API and docs
Panels created with `createCustomPanel` should be modifiable by the user and contain the model in the config. This was removed in a previous commit of this feature branch, but it is not wanted. Revert this precise change. Note: eventually a better solution would be to allow this to be chosen by the user in the advanced options dialog, but until then we leave it as originally.
TaurusGui shows a message box to inform that the "safe mode" is used. This is too obtrusive, specially for automated tests. Log an info message in the console and show a short message in the status bar instead.
Extra config options
added 6 commits
July 14, 2020 15:18
The only current implementation of tren2d is guiqwt-based, and it does not support the "n" mode for the x_axis_mode option. Instead it supports "e". Change it in the CLI definition.
Allow to use `-xn` with the same effect as `-xe` as an option of trend2d
added 3 commits
August 4, 2020 17:39
Numpy Array's tostring is a deprecated alias for tobytes (also in py2.7). Use tobytes instead.
An out of place "exit" statement prevented the --config option to work in the plot and trend subcommands. Fix it.
|
IMHO, this is ready to be released. It would be great if other @taurus-org/integrators (specially from MAXIV, Solaris, Desy,.. ) review it and give a green light |
added 3 commits
August 6, 2020 23:39
Add conda dir and meta.yaml file to create taurus conda packages
Indicate that taurus is supported for python>=2.7
- avoid using deprecated imp module (use importlib) - avoid importing distutils - stop supporting setuptools <20.2 - remove obsolete comments
Closed
added 2 commits
August 7, 2020 01:38
In py35, the pathlib.Path object cannot be used directly with spec_from_file_location() and this breaks setup.py. Fix by converting to a str with as_posix()
Use the taurus-org/publish-conda-action just implemented in order to deploy to the taurus-org conda channel.
|
Given the lack of availability from other @taurus-org/integrators during this release, I do not expect any review coming, and therefore it makes no sense to continue delaying it. I am going to merge without peer-review. And please, have a look at #1140 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR to master for the official Jul20 release. Final tests (automatic and manual) should be done based on it before accepting the merge.
So, this is a call for help from @taurus-org/integrators and any other person willing to help to test this branch ASAP in their respective systems.
Environments in which the manual tests should be done (please leave a comment if you volunteer to do the tests in one of them or in some other)
Some GNU/Linux system with up-to date conda environment and latest py3.7 conda dependenciesNobody took the task, so it won't be done(please let us know in the comments of this PR if you plan to do some more manual tests)
Notes: