This repository has been archived by the owner on Mar 17, 2021. It is now read-only.
WIP: Delegate unsubscribe from events to Tango C++ (PyTango#292) #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tango C++ unsubscribe from any subscribed event in the DeviceProxy destructor. As workaround for PyTango#292 do not call unsubscribes in Taurus. Just mark the event type as unsubscribed so eventual event callbacks are ignored in push_event.
This was referenced Mar 20, 2020
|
The root issue was solved in tango-controls/cppTango#699. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tango C++ unsubscribe from any subscribed event in the DeviceProxy destructor. As workaround for PyTango#292 do not call unsubscribes in Taurus. Just mark the event type as unsubscribed so eventual event callbacks are ignored in push_event.
This PR is one of the options to workaround tango-controls/pytango#292. It still does not work properly. I found the Sardana testsuite hung in the following situation" no_unsub_bt.txt and no_unsub_py-bt.txt
. I plan to push another option with delegating the unsubscribe to a worker thread.