fix(windows): ignore resize events when minimized #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amrbashir
requested changes
Jun 21, 2023
amrbashir
approved these changes
Jun 26, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
Other information
On Windows when a window is minimized it is set to a minimum size, this size change event and subsequent resize of the webview causes events within the webview contents such as ResizeObervers to fire.
The resizing of the window when minimizing dates back to when Windows did not have a taskbar, and is still used today for cases when the taskbar is unavailable or for MDI (windows within windows). A quick explanation can be found here.
Neither Chrome or Firefox fire off ResizeObserver or DOM resize events when they are minimized on Windows.