Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: consistent with_html across platforms #966

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Jun 5, 2023

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Checklist

  • This PR will resolve #___
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary
  • It can be built on all targets and pass CI/CD.

Other information

@amrbashir amrbashir requested a review from a team as a code owner June 5, 2023 14:04
@amrbashir amrbashir requested a review from wusyong June 7, 2023 15:30
@wusyong
Copy link
Member

wusyong commented Jun 8, 2023

Why do we choose null instead of http://localhost? I feel like null origin is more restricted.

@amrbashir
Copy link
Member Author

  1. consistency across platforms, Windows already behaves this way.
  2. because it doesn't make sense to have an origin when serving a simple HTML string like using data:text/html,, instead, they should be using a custom protocol or a web server

@wusyong wusyong merged commit 2b56bfa into dev Jun 8, 2023
@wusyong wusyong deleted the refactor/consistent-with-html branch June 8, 2023 10:48
@github-actions github-actions bot mentioned this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants