-
-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/ draggable-region #92
Conversation
Awesome! This is super great to have. |
I tested this out and it worked really well except for two things:
|
|
I just checked it again and the 20px jump doesn't happen to me, I am using AwesomeWM though not Gnome or Kde so that doesn't count I guess. Not sure why it jumps 20px on your end. Last night I did have the 20px jump but I managed to fix it by passing |
@nklayman when you have a chance, can you try with the latest commit ? hopefully it is fixed |
Seems like that did it, nice work! |
Nice, we will have to wait for winit's PR to be merged though. |
Didn't the PR get merged already @amrbashir |
Yeah it is merged but winit hasn't released a new version yet so I can't finish the PR unless they publish or wry uses winit from a git rev |
I guess we can wait for next winit release? The PR can leave as is until then. |
Yeah it can wait, I just wanted to finish the PR while I can. |
@amrbashir Could you update the winit dependency to the commit that has this feature? |
I add a custom titlebar example mainly to test drag.
winit implementation will have to wait until this PR is merged.