Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): use correct method signature #917

Merged
merged 2 commits into from
Mar 31, 2023
Merged

fix(android): use correct method signature #917

merged 2 commits into from
Mar 31, 2023

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Mar 31, 2023 •
edited
Loading

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Checklist

  • This PR will resolve #___
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary
  • It can be built on all targets and pass CI/CD.

Other information

@amrbashir amrbashir requested a review from a team as a code owner March 31, 2023 14:35
@amrbashir amrbashir merged commit c22744a into dev Mar 31, 2023
@amrbashir amrbashir deleted the fix/android/url branch March 31, 2023 15:23
@github-actions github-actions bot mentioned this pull request Mar 31, 2023
Merged
@Kijewski Kijewski mentioned this pull request Aug 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amrbashir @lucasfernog