On Linux, add header feature flag to fix version regression #766
Conversation
Cargo.toml
Outdated
| @@ -31,6 +31,7 @@ tray = [ "tao/tray" ] | |||
| devtools = [ ] | |||
| transparent = [ ] | |||
| fullscreen = [ ] | |||
| header = [ "webkit2gtk/v2_36" ] | |||
There was a problem hiding this comment.
maybe we should call it linux-headers or linux-custom-protocol-headers?
There was a problem hiding this comment.
or maybe just make version features similar to webkit2gtk, for example the "audio without user interaction" fix/feature needs 2.36 apis too
There was a problem hiding this comment.
@FabianLars Do you have the link for audio link as reference?
There was a problem hiding this comment.
The test branch still exists: dev...autoplay-0.19
i'll add a link to the docs to this comment once i find it again
There was a problem hiding this comment.
I'll pretend I didn't see that. 🙈
@lucasfernog and I want to do some workaround in webkit2gtk and we can just check version during runtime.
After that, I'll switch flatpak and bring to v2 soon.
There was a problem hiding this comment.
I tried to remove feature flags in webkit2gtk-rs but there are too many. I fear that will cause trouble in future updates. I would like to ask to consider this PR again.
There was a problem hiding this comment.
Let's do it this way for now. if we need more version-related feature flags, we can either change it or recommend users to add the webkit2gtk dependency and define the feature they need.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information
fix tauri-apps/tauri#5625