Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable devtools in debug mode by default #741

Merged
merged 2 commits into from
Oct 27, 2022
Merged

feat: enable devtools in debug mode by default #741

merged 2 commits into from
Oct 27, 2022

Conversation

amrbashir
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir requested a review from a team as a code owner October 27, 2022 13:29
wusyong
wusyong reviewed Oct 27, 2022
View reviewed changes
Copy link
Member

@wusyong wusyong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but this should be documented in the feature flag I think.

@amrbashir
Copy link
Member Author

It was documented in the flag, there was a small mistake for macOS note, I fixed.

@amrbashir amrbashir merged commit fea0638 into dev Oct 27, 2022
@amrbashir amrbashir deleted the devtools-debug branch October 27, 2022 13:42
@github-actions github-actions bot mentioned this pull request Oct 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wusyong wusyong wusyong left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amrbashir @wusyong