Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use http crate primitives instead of a custom impl #706

Merged
merged 7 commits into from
Sep 29, 2022

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Sep 28, 2022

Closes #668

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

This allows for better integration with the ecosystem and paves the way for streaming request/response body using http-body crate

@amrbashir amrbashir requested a review from a team as a code owner September 28, 2022 20:44
@amrbashir amrbashir marked this pull request as draft September 28, 2022 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] Replace http module with hyper re-export
1 participant