Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(macos): set titlebar style to none #566

Merged
merged 1 commit into from
May 2, 2022
Merged

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

This isn't exactly a bug, but it's also not something I could see in other macOS applications, so I just set it to none.

See tauri-apps/tauri#3801

@lucasfernog lucasfernog requested a review from a team May 1, 2022 23:15
@lucasfernog lucasfernog requested a review from a team as a code owner May 1, 2022 23:15
@wusyong wusyong merged commit 9776fc4 into dev May 2, 2022
@wusyong wusyong deleted the fix/macos-titlebar-style branch May 2, 2022 04:47
@github-actions github-actions bot mentioned this pull request May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants