Fix rustdoc generation of Windows and Mac on docs.rs, fix #503 #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasfernog
reviewed
Feb 21, 2022
|
Are you sure it builds without the default features? I thought we only needed to use the objc/exception feature as a default feature. |
|
No, it's not. That's why I set the features need to use in docs.rs |
lucasfernog
reviewed
Feb 27, 2022
Cargo.toml
Outdated
| @@ -78,5 +78,5 @@ sys-info = "0.9" | |||
| [target."cfg(any(target_os = \"ios\", target_os = \"macos\"))".dependencies] | |||
| cocoa = "0.24" | |||
| core-graphics = "0.22" | |||
| objc = { version = "0.2", features = [ "exception" ] } | |||
| objc = { version = "0.2", features = ["exception"] } | |||
There was a problem hiding this comment.
you still need to remove the feature here right? since it's enabled with default features now
lucasfernog
approved these changes
Feb 27, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information