Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(macOS): Runtime panic when no file_drop_handler #177

Merged
merged 2 commits into from
Apr 21, 2021
Merged

bug(macOS): Runtime panic when no file_drop_handler #177

merged 2 commits into from
Apr 21, 2021

Conversation

lemarier
Copy link
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Documentation
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

Other information:

Fix #176

@lemarier lemarier requested a review from a team as a code owner April 20, 2021 16:22
@lemarier lemarier requested a review from a team April 20, 2021 16:22
wusyong
wusyong approved these changes Apr 21, 2021
View reviewed changes
Copy link
Member

@wusyong wusyong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wusyong wusyong merged commit 22a4991 into dev Apr 21, 2021
@wusyong wusyong deleted the fix/macos-panic branch April 21, 2021 02:57
@github-actions github-actions bot mentioned this pull request Apr 21, 2021
Merged
@lemarier lemarier mentioned this pull request Apr 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wusyong wusyong wusyong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Runtime panic when no file_drop_handler defined on macOS
2 participants
@lemarier @wusyong