Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle webkit2gtk close signal #1311

Merged
merged 2 commits into from
Jul 15, 2024
Merged

handle webkit2gtk close signal #1311

merged 2 commits into from
Jul 15, 2024

Conversation

bukowa
Copy link
Contributor

@bukowa bukowa commented Jul 4, 2024

While working with selenium and tauri i wasn't able to close the window with WebKitWebDriver - now calling driver.close works.

from docs: https://webkitgtk.org/reference/webkit2gtk/2.5.1/WebKitWebView.html#WebKitWebView-close

Emitted when closing a WebKitWebView is requested. This occurs when a call is made from JavaScript's window.close function. It is the owner's responsibility to handle this signal to hide or destroy the WebKitWebView, if necessary.

Signed-off-by: Mateusz Kurowski <gitbukowa@gmail.com>
@bukowa bukowa requested a review from a team as a code owner July 4, 2024 23:37
Copy link
Contributor

github-actions bot commented Jul 5, 2024

Package Changes Through e587e39

There are 1 changes which include wry with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
wry 0.41.0 0.41.1

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

Signed-off-by: Mateusz Kurowski <gitbukowa@gmail.com>
@wusyong wusyong merged commit 03cdf93 into tauri-apps:dev Jul 15, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants