fix: use TARGET env var instead of cfg_aliases so cross compiling works #1217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amrbashir
previously approved these changes
Apr 9, 2024
|
android target will fail to build it seems. |
|
fix pushed |
pewsheen
reviewed
Apr 15, 2024
src/wkwebview/mod.rs
Outdated
| @@ -112,6 +112,7 @@ impl InnerWebView { | |||
| pl_attrs: super::PlatformSpecificWebViewAttributes, | |||
| _web_context: Option<&mut WebContext>, | |||
| ) -> Result<Self> { | |||
| println!("N"); | |||
amrbashir
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been facing random issues when cross compiling wry. When running
cargo xwin build --target x86_64-pc-windows-msvc, sometimes the build script enables the gtk alias. So I thought its better to detect the target platform manually with the TARGET env var.