-
-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: migrate to dpi
crate
#1202
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@pewsheen could you review the macOS part and make sure it works fine and is correctly using the right type (logical/physical) when retrieving and setting bounds? |
Looks good on macOS 👍 |
pewsheen
reviewed
Mar 28, 2024
Co-authored-by: Jason Tsai <jason@pews.dev>
amrbashir
commented
Mar 28, 2024
pewsheen
approved these changes
Mar 28, 2024
pewsheen
added a commit
that referenced
this pull request
Apr 2, 2024
* refactor: migrate to `dpi` crate closes #1172 * macOS * linux * fix doctests * imports * more doctests * fix android and ios * Update examples/winit.rs Co-authored-by: Jason Tsai <jason@pews.dev> * Update src/webview2/mod.rs --------- Co-authored-by: Jason Tsai <jason@pews.dev>
lucasfernog
added a commit
that referenced
this pull request
Oct 11, 2024
* migrate drag & drop * refactor: migrate to `dpi` crate (#1202) * refactor: migrate to `dpi` crate closes #1172 * macOS * linux * fix doctests * imports * more doctests * fix android and ios * Update examples/winit.rs Co-authored-by: Jason Tsai <jason@pews.dev> * Update src/webview2/mod.rs --------- Co-authored-by: Jason Tsai <jason@pews.dev> * fix(windows): avoid double-free the controller (#1206) * fix(linux): Disable deprecated applicationCache web api. (#1207) fixes tauri-apps/tauri#9300 ref WebKit/WebKit#23382 * fix(wkwebview): menu shortcuts (#1208) * fix(wkwebview): menu shortcuts * Update wkwebview.md * Apply Version Updates From Current Changes (#1203) Co-authored-by: amrbashir <amrbashir@users.noreply.github.com> * migrate to `objc2` * fix(macos): response body being double freed * fix(macos): eval callback NSStrgin convertion error * chore: remove objc dependency * refactor(macos): migrate WebViewDelegate * refactor(macos): migrate proxy to objc2 * refactor(macos): migrate document title change observer to objc2 * refactor(macos): move drag&drop handler to delegate * refactor(macos): move ipc_handler into WryWebViewDelegate * refactor(macos): migrate download handler * fix(macos): prevent unsafe async custom protocol panic * chore: target os import * refactor(ios): migrate to objc2 * refactor(macos): migrate WebViewUIDelegate to objc2 * refactor(macos): migrate WryWebViewParent to objc2 * refactor(macos): move custom class to individual files * chore: fix clippy * refector: use reference for task. use objc2::exception::catch. * fix(dnd): use msg_send super and impl NSDraggingDestination * chore: call msg_send super * fix: wrap Box<dyn FnMut(..)> with RefCell * chore(deps): update rust crate tao to 0.29 (#1343) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * refactor: use bitflags way to handle mask bit manipulation * WIP: refactor(ios): add wkwebview for ios * Update Cargo.toml Co-authored-by: Mads Marquart <mads@marquart.dk> * fix: remove `.copy()` from RcBlock * add change file * lint * fmt --------- Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com> Co-authored-by: Fabian-Lars <fabianlars@fabianlars.de> Co-authored-by: thewh1teagle <61390950+thewh1teagle@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: amrbashir <amrbashir@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Mads Marquart <mads@marquart.dk> Co-authored-by: Lucas Nogueira <lucas@tauri.app>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1172
closes tauri-apps/tauri#9264