Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mac): suppress duplicated media permission prompt #1186

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

pewsheen
Copy link
Contributor

@pewsheen pewsheen commented Mar 11, 2024

Issue: tauri-apps/tauri#8979
Original fix: #1101

I've tested it on my macOS 14.2.1. It would be better to have a second check.

A minimal testing repo: https://github.com/pewsheen/tauri-media-permission/

@pewsheen pewsheen requested a review from a team as a code owner March 11, 2024 08:06
@pewsheen pewsheen marked this pull request as draft March 11, 2024 08:29
@pewsheen pewsheen marked this pull request as ready for review March 11, 2024 08:55
@wusyong wusyong merged commit ae64a09 into dev Mar 11, 2024
12 checks passed
@wusyong wusyong deleted the fix/duplicate-media-permission-prompt branch March 11, 2024 12:00
@stolinski
Copy link

Is there a chance that this broke getDisplayMedia? I am unable to get the getDisplayMedia permissions prompt and when adding a

        const stream = await navigator.mediaDevices.getDisplayMedia({
          video: true, // Screen capture
          audio: false, // No audio capture
        });

to your test repo for tauri-media-permissions, it once again gives the same
"Unhandled Promise Rejection: NotAllowedError: The request is not allowed by the user agent or the platform in the current context, possibly because the user denied permission."
error without a permissions prompt.

@pewsheen
Copy link
Contributor Author

What's your OS version and did you run the repo by tauri dev or the bundled .app application?

@stolinski
Copy link

stolinski commented Mar 18, 2024

Edit: Moving this to tauri-apps/tauri#2600

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getDisplayMedia() does not work on MacOS Sonoma 14.0+
3 participants