Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add WebView::bounds getter #1091

Merged
merged 11 commits into from
Nov 22, 2023
Merged

feat: add WebView::bounds getter #1091

merged 11 commits into from
Nov 22, 2023

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Checklist

  • This PR will resolve #___
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary
  • It can be built on all targets and pass CI/CD.

Other information

@lucasfernog lucasfernog requested a review from a team as a code owner November 21, 2023 19:01
amrbashir
amrbashir requested changes Nov 21, 2023
View reviewed changes
src/webview2/mod.rs Outdated Show resolved Hide resolved
src/wkwebview/mod.rs Outdated Show resolved Hide resolved
src/webkitgtk/mod.rs Show resolved Hide resolved
src/webkitgtk/mod.rs Show resolved Hide resolved
@lucasfernog
Copy link
Member Author

also fixed an issue with the webview size on macOS. let me know if you want a separate PR

@amrbashir amrbashir merged commit 8fddbb6 into dev Nov 22, 2023
@amrbashir amrbashir deleted the feat/bounds-getter branch November 22, 2023 13:45
@github-actions github-actions bot mentioned this pull request Nov 22, 2023
Merged
@rhysd rhysd mentioned this pull request Dec 2, 2023
Closed
2 tasks
yydcnjjw pushed a commit to yydcnjjw/wry that referenced this pull request Feb 5, 2024
@lucasfernog @amrbashir
feat: add WebView::bounds getter (tauri-apps#1091)
3893521 
* feat: add WebView::bounds getter

* macos impl

* windows impl

* dummy android

* fix build on ios

* fix initial size on macOS, adjust bounds impl

* fallback to controller.bounds on windows

* use webview.allocated_size on linux when not a child

* cleanup windows impl

* fix wgpu example

* cleanup linux impl

---------

Co-authored-by: amrbashir <amr.bashir2015@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrbashir amrbashir amrbashir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucasfernog @amrbashir