Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wry 0.16.1 does not build on macos #580

Closed
1 of 2 tasks
FrankenApps opened this issue May 10, 2022 · 0 comments · Fixed by #582
Closed
1 of 2 tasks

Wry 0.16.1 does not build on macos #580

FrankenApps opened this issue May 10, 2022 · 0 comments · Fixed by #582

Comments

@FrankenApps
Copy link
Contributor

FrankenApps commented May 10, 2022

Describe the bug
The build of the crate fails on macos.

This is the error message:

error[E0308]: mismatched types
   --> /Users/me/.cargo/registry/src/github.com-1ecc6299db9ec823/wry-0.16.1/src/webview/wkwebview/mod.rs:420:12
    |
420 |         if can_set_titlebar_style {
    |            ^^^^^^^^^^^^^^^^^^^^^^ expected `bool`, found `i8`

error[E0308]: mismatched types
   --> /Users/me/.cargo/registry/src/github.com-1ecc6299db9ec823/wry-0.16.1/src/webview/wkwebview/mod.rs:549:10
    |
549 |       if can_print {
    |          ^^^^^^^^^ expected `bool`, found `i8`

For more information about this error, try `rustc --explain E0308`.
error: could not compile `wry` due to 2 previous errors
warning: build failed, waiting for other jobs to finish...
error: build failed

Steps To Reproduce
Try to build the crate using cargo build.

Expected behavior
The build should succeed.

Platform and Versions (please complete the following information):
OS: MacOS 12.3.1
Rustc: rustc 1.60.0 (7737e0b5c 2022-04-04)

Would you assign yourself to resolve this bug?

  • Yes
  • No

Additional context
The bug seems to have been introduced in eb2dddb.

However I have no idea how it was possible, that this slipped the Github Actions CI?

FrankenApps added a commit to FrankenApps/wry that referenced this issue May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant