feat: add theme feature on Linux, closes #387 #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
01b3441 to
ae69888
Compare
ae69888 to
0447edf
Compare
wusyong
reviewed
Jul 9, 2022
wusyong
approved these changes
Jul 10, 2022
Merged
lucasfernog
reviewed
Aug 2, 2022
| if let Some(theme) = theme_name { | ||
| // Currently GTK doesn't provide feature for detect theme, so we need to check theme manually. | ||
| // ref: https://github.com/WebKit/WebKit/blob/e44ffaa0d999a9807f76f1805943eea204cfdfbc/Source/WebKit/UIProcess/API/gtk/PageClientImpl.cpp#L587 | ||
| if theme.ends_with("-dark") || theme.ends_with("-Dark") { |
There was a problem hiding this comment.
probably should be
Suggested change
| if theme.ends_with("-dark") || theme.ends_with("-Dark") { | |
| if theme.contains("-dark") || theme.contains("-Dark") { |
There was a problem hiding this comment.
Darker ... I see. I will fix this issue.
There was a problem hiding this comment.
@lucasfernog
I created the PR. Could you check it when you have time?
#511
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information
Currently GTK does not support theme changed event...