-
-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(macos): add SystemTray::set_tooltip
, ref #409
#410
Conversation
Hi, sorry to bother @wusyong , is it ok to continue work on this? |
@pevers sorry for the delay. It would be perfect if you can finish Linux and Windows implementation but if you don't want too I can merge this and add them later. |
55d6929
to
0fcf1c7
Compare
Thanks for your reply @amrbashir ! I currently don't have access to my Windows machine, so I updated this PR and I can create an issue for the Windows and Linux implementation if that is OK? |
It is fine, I will add them in this PR tomorrow or later today. |
Sorry for the delay, I totally forgot I was going to implement other platforms. It seems Linux's libappindicator doesn't support setting tooltips so I refactored the PR a bit for future Windows implementation because I can't do it right now. |
SystemTray::set_tooltip
, ref #409
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
What kind of change does this PR introduce?
This implements the
set_tool_tip
method on a tray. I understand that this will probably not be merged before the v1 release. Please let me know if I can continue to work on this to also support the other platforms or if you would rather wait.This should close #409
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___
)Other information