refactor!: revert {task_workdir} interpolation in run-task environment #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b76bd5e to
bee1612
Compare
bhearsum
approved these changes
Feb 18, 2025
In hindsight, this ended up being a bad idea and caused lots of subtle issues in Gecko. As an alternative, I landed a change to get generic-worker itself to set $TASK_WORKDIR. This will take awhile to propagate to all pools, but in the meantime it's cleanest to revert back to the abspath method.
bee1612 to
fd28d02
Compare
|
Tested here: I see it working with both docker-worker and Windows generic-worker tasks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In hindsight, this ended up being a bad idea and caused lots of subtle issues in Gecko. As an alternative, I landed a change to get generic-worker itself to set $TASK_WORKDIR.
This will take awhile to propagate to all pools, but in the meantime it's cleanest to revert back to the abspath method.