fix: chain of trust should influence cache digest #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chain of trust being enabled or disabled influences the outcome of a task. Specifically, it controls whether or not chain of trust artifacts will be present on the task. Without this impacting the cache digest, cached tasks will continue to be cached when chain of trust is enabled on them, and if there is a chain of trust verifier downstream, this will cause verification issues. BREAKING CHANGE: worker.chain-of-trust now influences cache digests
|
I don't fully understand this one. So I am deferring to someone else in @taskcluster/releng |
jcristau
approved these changes
Jun 6, 2024
|
I'm not sure this should be considered a breaking change.. It doesn't require any code updates in consumer repos right? It'll just invalidate their caches. |
bhearsum
added a commit
to bhearsum/firefox-translations-training
that referenced
this pull request
Jun 11, 2024
This is primarily to pick up taskcluster/taskgraph#514, which will be needed for mozilla#466.
bhearsum
added a commit
to bhearsum/firefox-translations-training
that referenced
this pull request
Jun 12, 2024
This is primarily to pick up taskcluster/taskgraph#514, which will be needed for mozilla#466.
bhearsum
added a commit
to bhearsum/firefox-translations-training
that referenced
this pull request
Jun 12, 2024
This is primarily to pick up taskcluster/taskgraph#514, which will be needed for mozilla#466.
bhearsum
added a commit
to bhearsum/firefox-translations-training
that referenced
this pull request
Jun 19, 2024
This is primarily to pick up taskcluster/taskgraph#514, which will be needed for mozilla#466.
bhearsum
added a commit
to bhearsum/firefox-translations-training
that referenced
this pull request
Jun 19, 2024
This is primarily to pick up taskcluster/taskgraph#514, which will be needed for mozilla#466.
bhearsum
added a commit
to bhearsum/firefox-translations-training
that referenced
this pull request
Jun 19, 2024
This is primarily to pick up taskcluster/taskgraph#514, which will be needed for mozilla#466.
bhearsum
added a commit
to mozilla/translations
that referenced
this pull request
Jun 19, 2024
This is primarily to pick up taskcluster/taskgraph#514, which will be needed for #466.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chain of trust being enabled or disabled influences the outcome of a task. Specifically, it controls whether or not chain of trust artifacts will be present on the task. Without this impacting the cache digest, cached tasks will continue to be cached when chain of trust is enabled on them, and if there is a chain of trust verifier downstream, this will cause verification issues.
BREAKING CHANGE: worker.chain-of-trust now influences cache digests