Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Use docker slim images where possible #454

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Conversation

hneiva
Copy link
Contributor

@hneiva hneiva commented Feb 8, 2024

No description provided.

@hneiva hneiva force-pushed the hneiva/docker-slim-images branch from 56bb52e to cf59344 Compare February 8, 2024 13:55
@hneiva hneiva requested review from a team and jcristau February 8, 2024 14:11
@hneiva hneiva force-pushed the hneiva/docker-slim-images branch from cf59344 to 948b50c Compare February 9, 2024 09:17
@hneiva hneiva force-pushed the hneiva/docker-slim-images branch 3 times, most recently from 2d2cb03 to 8f83573 Compare February 12, 2024 16:54
@hneiva hneiva marked this pull request as draft February 12, 2024 20:03
@hneiva hneiva force-pushed the hneiva/docker-slim-images branch 3 times, most recently from 4d4b5f3 to 35721d4 Compare February 13, 2024 13:42
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (97be118) 60.18% compared to head (0f1ef4e) 60.24%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #454      +/-   ##
==========================================
+ Coverage   60.18%   60.24%   +0.06%     
==========================================
  Files          69       69              
  Lines        6409     6424      +15     
  Branches     1292     1484     +192     
==========================================
+ Hits         3857     3870      +13     
- Misses       2266     2268       +2     
  Partials      286      286              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hneiva hneiva force-pushed the hneiva/docker-slim-images branch from 35721d4 to 0f1ef4e Compare February 13, 2024 14:18
@hneiva hneiva marked this pull request as ready for review February 13, 2024 16:38
@hneiva hneiva requested a review from bhearsum February 13, 2024 16:38
Copy link
Contributor

@bhearsum bhearsum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to stick with this approach I'm good with it. I think we also talked about using separate images per Python version to avoid building a bunch of Python versions ourselves in one giant image? Up to you.

@hneiva
Copy link
Contributor Author

hneiva commented Feb 14, 2024

If you want to stick with this approach I'm good with it. I think we also talked about using separate images per Python version to avoid building a bunch of Python versions ourselves in one giant image? Up to you.

Yeah, since it's a bigger refactor I think we should do it in a separate issue.

@hneiva hneiva merged commit cf49312 into main Feb 14, 2024
14 checks passed
@hneiva hneiva deleted the hneiva/docker-slim-images branch February 14, 2024 16:37
@hneiva hneiva restored the hneiva/docker-slim-images branch February 14, 2024 16:37
@hneiva hneiva deleted the hneiva/docker-slim-images branch February 14, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants