-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Use docker slim images where possible #454
Conversation
56bb52e
to
cf59344
Compare
cf59344
to
948b50c
Compare
2d2cb03
to
8f83573
Compare
4d4b5f3
to
35721d4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #454 +/- ##
==========================================
+ Coverage 60.18% 60.24% +0.06%
==========================================
Files 69 69
Lines 6409 6424 +15
Branches 1292 1484 +192
==========================================
+ Hits 3857 3870 +13
- Misses 2266 2268 +2
Partials 286 286 ☔ View full report in Codecov by Sentry. |
35721d4
to
0f1ef4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to stick with this approach I'm good with it. I think we also talked about using separate images per Python version to avoid building a bunch of Python versions ourselves in one giant image? Up to you.
Yeah, since it's a bigger refactor I think we should do it in a separate issue. |
No description provided.