feat(init): support pr-action in the template .taskcluster.yml #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
868e206 to
798e6fb
Compare
798e6fb to
fb4320f
Compare
ahal
approved these changes
Feb 13, 2024
| @@ -268,7 +278,7 @@ tasks: | |||
|
|
|||
| extra: | |||
| $merge: | |||
| - $if: 'tasks_for == "action"' | |||
| - $if: 'tasks_for in ["action", "pr-action"]' | |||
There was a problem hiding this comment.
It might be worth creating a new isAction variable for this, but I'm ok with leaving it too.
There was a problem hiding this comment.
Thanks for the review.
I did consider a new variable, but there's a few cases where action and pr-action are different, or where they're also the same as cron, so there'd still be a need to distinguish, and leaving it like this might be clearer in the end?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.