Bug 1641282 - support action tasks on github pull requests #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
59efc37 to
85b4d52
Compare
42aa4cc to
fdf0bab
Compare
|
This depends on #447. |
jcristau
commented
Feb 8, 2024
jcristau
commented
Feb 8, 2024
|
|
||
| # the scope should appear literally; no need for a satisfaction check. The use of | ||
| # get_current_scopes here calls the auth service through the Taskcluster Proxy, giving | ||
| # the precise scopes available to this task. | ||
| if expected_scope not in taskcluster.get_current_scopes(): | ||
| raise ValueError(f"Expected task scope {expected_scope} for this action") | ||
| if not set((action_scope, pr_action_scope)) & set(taskcluster.get_current_scopes()): |
There was a problem hiding this comment.
Is there a way to know here which scope to expect?
a519199 to
34362ec
Compare
- use "pr-action" instead of "action" hook and scope when registering an action from a pull-request graph - pass the base repo url and branch in the action payload: the base repo is what the scope should be based on, and the base repo+branch need to be passed back to action tasks so they can check out the right thing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.