Add ca_bundle_file and ca_certs_dir config options #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch (potentially) fixes tarickb#14. Indeed, this patch introduces the "ca_bundle_file" and "ca_certs_dir" configuration keys. From now on, "ca_bundle_file" will be plumbed into CURLOPT_CAINFO and "ca_certs_dir" into CURLOPT_CAPATH. However, when the value of "ca_certs_dir" is empty, we fallback to "ca_bundle_file" if it's not emtpy either.
|
@tarickb I find it hard to find the right place to document this in the README file ... Can you take over that part? |
tarickb
requested changes
Sep 11, 2022
|
@tarickb I took over the requested changes. Please review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch (potentially) fixes #14.
Indeed, this patch introduces the "ca_bundle_file" and "ca_certs_dir" configuration keys.
From now on, "ca_bundle_file" will be plumbed into CURLOPT_CAINFO and "ca_certs_dir" into CURLOPT_CAPATH. However, when the value of "ca_certs_dir" is empty, we fallback to "ca_bundle_file" if it's not empty either.