Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pgxpool: Don't use idle connections with stdlib when doing pooling #4137

Merged
merged 2 commits into from
Nov 11, 2024
Merged

pgxpool: Don't use idle connections with stdlib when doing pooling #4137

merged 2 commits into from
Nov 11, 2024

Conversation

mastercactapus
Copy link
Member

Description:
Removes connection management for sql.DB now that it's backed by a pgxpool.Pool.

  • Also, added validation that migration version matches to prevent using a switchover from an older version of GoAlert when newer DB migrations are present.

@mastercactapus mastercactapus merged commit 2d74e28 into master Nov 11, 2024
7 checks passed
@mastercactapus mastercactapus deleted the fix-db-pool-connections branch November 11, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m17ch m17ch m17ch approved these changes

@KatieMSB KatieMSB KatieMSB approved these changes

Assignees
No one assigned
Labels
size/s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mastercactapus @m17ch @KatieMSB