Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engine/schedulemanager: convert to sqlc #4116

Merged
merged 3 commits into from
Nov 6, 2024
Merged

Conversation

mastercactapus
Copy link
Member

Description:
Transitions the schedule manager to sqlc

  • most IDs are now handled natively as UUIDs
  • Queries are unchanged

- Consolidated SQL statement preparation into a single location.
- Removed redundant code by utilizing generated query functions.
- Improved readability and maintainability by separating SQL logic.
- Replaced string-based user IDs with UUIDs for consistency.
@github-actions github-actions bot added the size/l label Nov 1, 2024
Copy link
Contributor

@m17ch m17ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mastercactapus mastercactapus merged commit e0f8e20 into master Nov 6, 2024
7 checks passed
@mastercactapus mastercactapus deleted the sched-mgr-sqlc branch November 6, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants