engine/signal: Add signal manager module and support for sending signal messages #3975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced SignalManager to handle outgoing status updates - Added new processing lock type and enum 'signals' - Updated database schema with new signal module migrations - Implemented signal message types and related notification changes - Added SQL queries for handling pending signals operations
- Updated `cm_type_val_to_dest` and `nc_type_val_to_dest` functions to use underscore naming for JSON keys. - Added migrations to update existing records to the new format. - Created triggers for backward compatibility during insert operations.
- Implement fetching signal message parameters from the database - Update sendMessage to handle SignalMessage type with UUID parsing and JSON unmarshalling - Add migration to enum type for signal_message - Update field naming conventions to use underscores for better consistency - Create smoke tests for Signal message functionality
- Renamed `phone-number` to `phone_number` for consistency - Updated `webhook-url` to `webhook_url`
- Incremented message processing lock version to 10 - Added migration to update processing version in DB - Renamed existing migrations for clarity
- Updated comment to better describe the purpose of SignalMessage struct.
- Added `MessageTypeSignalMessage` with the lowest priority (99) in the message priority map.
Renamed to better reflect the role of scheduling outgoing signals.
- Added descriptions to SQL queries to enhance readability - Introduced 'signal_message' type to message enums - Provided documentation for query-related Go functions
Forfold
reviewed
Jul 9, 2024
Forfold
reviewed
Jul 9, 2024
Forfold
approved these changes
Jul 9, 2024
allending313
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
It adds the signal manager, which adds pending signals to the outgoing messages queue and supports sending signals to Slack.