sched/notif: retain time and weekday filter if swapping radio options #3741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Updates the
*Destvariant of the schedule notification form to preserve state of the time and weekday filter options.Out of Scope:
The old non-dest form was not updated; this is ONLY when the
dest-typesflag is set to use the new form and dialog code.Screenshots:
fix-sched-notif-bug.mp4
Describe any introduced user-facing changes:
N/A just a quality-of-life fix
Describe any introduced API changes:
N/A
Additional Info:
Note: The parent
props.valueandonChangehandlers still receive anulltime when the value changes (no effect on API). This fix is handled purely in the form's state.