fix: alert detail markdown link bug #3683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make checkto catch common errors. Fixed any that came up.Description:
User indicated that hyperlinks which should be rendered correctly via markdown were displayed as text. The issues seems to be that the
<ReactMarkdown>component checks for safeUrls with url and label where url is rendered with html entities causing special characters such as&to be converted to&. This messes with the accuracy of safeUrls regex checks resulting in false negatives thus causing ReactMarkdown to display the hyperlinks as plain text.Adding preprocessing in the form of
encodeHtmlEntities()ensures that the label/url comparisons are free of discrepancies caused by html entity conversions.Which issue(s) this PR fixes:
[For significant amounts of work, it is best to start an issue first, preferably before the work is started.
For large pull requests, be sure to reference the associated GitHub issue(s).]
#3628
Describe any introduced user-facing changes:
Markdowns should properly render hyperlinks where the url and label match