ep: fix webhook expansion when slack is disabled #3264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allending313
approved these changes
Sep 6, 2023
andrewbenington
approved these changes
Sep 6, 2023
1ddo
pushed a commit
to 1ddo/goalert
that referenced
this pull request
Sep 7, 2023
allending313
pushed a commit
that referenced
this pull request
Sep 11, 2023
allending313
added a commit
that referenced
this pull request
Sep 13, 2023
* add monthly rotation feat * update db-schema * revert migration update, create new migration * update models.go * update monthly start/end to be datetime-from-start-of-month * update monthly rotation logic * make db-schema && make generate * fix ts error * add monthly rotation smoke test * fix rotation tests * refactor smoke test * refactor shiftLengthHours to shiftLength * fix webhook expansion when slack is disabled (#3264) * dev: add local db url to dev setup guide (#3266) * add local db url to dev setup guide * clarify no pass * Bump react-redux from 8.1.1 to 8.1.2 (#3269) Bumps [react-redux](https://github.com/reduxjs/react-redux) from 8.1.1 to 8.1.2. - [Release notes](https://github.com/reduxjs/react-redux/releases) - [Changelog](https://github.com/reduxjs/react-redux/blob/master/CHANGELOG.md) - [Commits](reduxjs/react-redux@v8.1.1...v8.1.2) --- updated-dependencies: - dependency-name: react-redux dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump eslint-plugin-import from 2.27.5 to 2.28.1 (#3268) Bumps [eslint-plugin-import](https://github.com/import-js/eslint-plugin-import) from 2.27.5 to 2.28.1. - [Release notes](https://github.com/import-js/eslint-plugin-import/releases) - [Changelog](https://github.com/import-js/eslint-plugin-import/blob/main/CHANGELOG.md) - [Commits](import-js/eslint-plugin-import@v2.27.5...v2.28.1) --- updated-dependencies: - dependency-name: eslint-plugin-import dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump actions/checkout from 3 to 4 (#3267) Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * preserve field/type information when parsing ISODuration (#3272) * add monthly rotation feat * update db-schema * revert migration update, create new migration * update monthly rotation logic * make db-schema && make generate * refactor monthly rotation api * fix rotation test * move new migration to the end * cleanup CalcRotationHandoffTimes and fix missing Start * add missing validation and fix error * fix deprecation warning * polish * revert whitespace change (will fail on CI otherwise) * fix schema.sql out of date * add comments to new rotation logic * minor fixes for clarity * revert timeFormat test corrections * fix page crash if rotation is monthly --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: AllenDing <Allen.Ding@target.com> Co-authored-by: Nathaniel Caza <mastercactapus@gmail.com> Co-authored-by: Nathaniel Cook <nathanieljcook@outlook.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes an issue that prevents configuring webhooks when Slack is disabled.
The current step index for webhooks changes based on whether
Slack.Enableis set or not, but the logic was incorrectly checking theWebhook.Enableflag.Which issue(s) this PR fixes:
Fixes #3263
Additional Info:
This logic should be greatly simplified with the completion of #3206