Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support arg+ syntax for argument capture (w/ fixes) #116

Merged
merged 2 commits into from
Nov 5, 2019
Merged

Support arg+ syntax for argument capture (w/ fixes) #116

merged 2 commits into from
Nov 5, 2019

Conversation

wass3r
Copy link
Collaborator

@wass3r wass3r commented Oct 24, 2019 •
edited
Loading

Clone of #108 w/ fixes

Resolves #107

@coveralls
Copy link

Pull Request Test Coverage Report for Build 245

  • 12 of 26 (46.15%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 40.121%
Changes Missing Coverage Covered Lines Changed/Added Lines %
core/matcher.go 12 26 46.15%
Files with Coverage Reduction New Missed Lines %
core/matcher.go 1 85.6%
Totals Coverage Status
Change from base Build 243: 0.03%
Covered Lines: 796
Relevant Lines: 1984
💛 - Coveralls

@wass3r wass3r merged commit c3767d1 into master Nov 5, 2019
@wass3r wass3r deleted the arg-plus branch November 5, 2019 06:33
@wass3r wass3r mentioned this pull request Nov 5, 2019
Closed
5 tasks
@wass3r wass3r mentioned this pull request Jan 25, 2020
Open
@wass3r wass3r mentioned this pull request Sep 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JordanSussman JordanSussman JordanSussman approved these changes

@pa3ng pa3ng Awaiting requested review from pa3ng

@sjqnn sjqnn Awaiting requested review from sjqnn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Variable for all remaining args in rule
3 participants
@wass3r @coveralls @JordanSussman