Fix indentation in c extension #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@orbitfold I hope the settings i used implement the right indentation sheme. If there is anything wrong, i'll fix it. |
|
So coverage decreased by 0.0%? Nice catch coveralls! |
|
@orbitfold - is this in line with our c-conventions? @yeganer - this needs a rebase. |
|
I'll look in to it shortly. |
| { | ||
| imin = imid; | ||
| } | ||
| imid = (imin + imax)>>1; |
There was a problem hiding this comment.
There should be spaces after and before the bitshift operator.
|
@yeganer - rebase. |
Applied the GNU C coding convention to most files in the c extension.
The following settings were used with vim:
setlocal cindent
setlocal cinoptions=>4,n-2,{2,^-2,:2,=2,g0,h2,p5,t0,+2,(0,u0,w1,m1
setlocal sw=2
setlocal sts=2
setlocal tw=79
setlocal fo-=ro fo +=cql
7bdc93f to
87ef34a
Compare
|
@wkerzendorf : done. Including fix for bitshift. |
|
@orbitfold @unoebauer any other comments - otherwise I'll merge after lunch. |
|
Fine with me |
wkerzendorf
added a commit
that referenced
this pull request
Feb 17, 2016
Fix indentation in c extension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applied the GNU C coding convention to most files in the c extension.
The following settings were used with vim: