Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename tau to tau event #2931

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+6 −5
Open

rename tau to tau event #2931

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5aa2275
rename tau to tau event
karthik11135 Jan 9, 2025
3e30f3a
mailmap change
karthik11135 Jan 9, 2025
f85f7b8
rename at other places
karthik11135 Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .mailmap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,8 @@ Josh Shields <shields.joshua.v@gmail.com>
Karan Desai <karandesai_96@live.com>
Karan Desai <karandesai_96@live.com> karandesai-96 <karandesai_96@live.com>

Karthik Rishinarada <karthikrk11135@gmail.com>

Kaushik Varanasi <kaushik.varanasi1@gmail.com>
Kaushik Varanasi <kaushik.varanasi1@gmail.com> kaushik94 <kaushik.varanasi1@gmail.com>

Expand Down
3 changes: 1 addition & 2 deletions tardis/energy_input/GXPacket.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,7 @@ def __init__(
self.status = status
self.shell = shell
self.time_current = time_current
# TODO: rename to tau_event
self.tau = -np.log(np.random.random())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the only place where it is used throughout the codebase?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope. Few other places are there where this is used. Sorry about that. I'll update the PR.

self.tau_event = -np.log(np.random.random())

def get_location_r(self):
"""Calculate radius of the packet
Expand Down
Loading