Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove parameters and speed up benchmarks #2717

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

officialasishkumar
Copy link
Member

@officialasishkumar officialasishkumar commented Jul 18, 2024

📝 Description

Type: 🪲 bugfix

  • Fixed the failing benchmarks.
  • Speed up benchmarks by only running every benchmark once.
  • Removed parameters with close results in terms of time.

https://github.com/officialasishkumar/tardis/actions/runs/9987846474/job/27603058268#logs (earlier it used to take 1hr 22mins)

📌 Resources

Examples, notebooks, and links to useful references.

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>
@officialasishkumar officialasishkumar requested review from andrewfullard and atharva-2001 and removed request for andrewfullard July 18, 2024 13:10
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.47%. Comparing base (c107f27) to head (a70e807).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2717   +/-   ##
=======================================
  Coverage   36.47%   36.47%           
=======================================
  Files         183      183           
  Lines       14664    14664           
=======================================
  Hits         5348     5348           
  Misses       9316     9316           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>
Copy link
Contributor

@andrewfullard andrewfullard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why the benchmarks are still complaining, but they don't seem to be using the version in this PR which seems to have the correct trace_vpacket_volley parameters.

@DeerWhale DeerWhale merged commit 491eb67 into tardis-sn:master Jul 19, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants