Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move rpacket_trackers_to_dataframe function to packet_trackers.py file #2647

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Move rpacket_trackers_to_dataframe function to packet_trackers.py file #2647

merged 2 commits into from
Jun 7, 2024

Conversation

Sumit112192
Copy link
Contributor

@Sumit112192 Sumit112192 commented Jun 7, 2024 •
edited
Loading

📝 Description

Type: 🎢 restructure

Moved RPacketTracker related function to packet_trackers.py file

🚦 Testing

How did you test these changes?

pytest tardis

@Sumit112192 Sumit112192 marked this pull request as ready for review June 7, 2024 16:08
andrewfullard
andrewfullard approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@andrewfullard andrewfullard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another sensible refactor, thanks

@andrewfullard andrewfullard requested a review from afloers June 7, 2024 16:09
@wkerzendorf wkerzendorf merged commit 1576ea8 into tardis-sn:master Jun 7, 2024
10 checks passed
@Sumit112192 Sumit112192 deleted the MoveRPacketTrackerFunctionToOneFile branch September 8, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewfullard andrewfullard andrewfullard approved these changes

@afloers afloers Awaiting requested review from afloers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sumit112192 @andrewfullard @wkerzendorf