-
-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move RPacketTracker class to a new file packet_trackers.py #2638
Move RPacketTracker class to a new file packet_trackers.py #2638
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2638 +/- ##
=======================================
Coverage 67.76% 67.76%
=======================================
Files 171 172 +1
Lines 14411 14415 +4
=======================================
+ Hits 9765 9769 +4
Misses 4646 4646 ☔ View full report in Codecov by Sentry. |
is this in a state that it should be reviewed? |
This PR should only move the |
I will do that. Thanks. |
looks - good. you can now do a PR on this PR. |
@wkerzendorf This PR only moves the RPacketTracker Class to a new file packet_trackers.py and is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good refactor, thanks
📝 Description
Type: 🎢
restructure
This pull request is going to handle the following task
🚦 Testing
How did you test these changes?
pytest tardis
☑️ Checklist
build_docs
label