Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move RPacketTracker class to a new file packet_trackers.py #2638

Merged
merged 10 commits into from
Jun 6, 2024

Conversation

Sumit112192
Copy link
Contributor

@Sumit112192 Sumit112192 commented Jun 1, 2024

📝 Description

Type: 🎢 restructure
This pull request is going to handle the following task

  • Move the Existing RPacketTracker class to a new file packet_trackers.py

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

pytest tardis

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

Copy link

codecov bot commented Jun 1, 2024

Codecov Report

Attention: Patch coverage is 18.75000% with 52 lines in your changes missing coverage. Please review.

Project coverage is 67.76%. Comparing base (199b03f) to head (1beb05c).
Report is 4 commits behind head on master.

Current head 1beb05c differs from pull request most recent head fd38d0a

Please upload reports for the commit fd38d0a to get more accurate results.

Files Patch % Lines
tardis/transport/montecarlo/packet_trackers.py 14.75% 52 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2638   +/-   ##
=======================================
  Coverage   67.76%   67.76%           
=======================================
  Files         171      172    +1     
  Lines       14411    14415    +4     
=======================================
+ Hits         9765     9769    +4     
  Misses       4646     4646           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wkerzendorf
Copy link
Member

is this in a state that it should be reviewed?

@wkerzendorf
Copy link
Member

This PR should only move the RPacketTracker class to packet_trackers. It also introduces a LastInteractionTracker which should be a different PR.

@Sumit112192
Copy link
Contributor Author

This PR should only move the RPacketTracker class to packet_trackers. It also introduces a LastInteractionTracker which should be a different PR.

I will do that. Thanks.

@Sumit112192 Sumit112192 marked this pull request as ready for review June 6, 2024 18:51
@wkerzendorf
Copy link
Member

looks - good. you can now do a PR on this PR.

@Sumit112192
Copy link
Contributor Author

@wkerzendorf This PR only moves the RPacketTracker Class to a new file packet_trackers.py and is ready for review.

Copy link
Contributor

@andrewfullard andrewfullard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good refactor, thanks

@wkerzendorf wkerzendorf merged commit 6fffa69 into tardis-sn:master Jun 6, 2024
10 checks passed
@Sumit112192 Sumit112192 deleted the TrackerClassRefactor branch September 8, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants